Repository navigation
Avoid unrelated span reads for allowed unreachable-code lints - #391
Open
charliermarsh wants to merge 1 commit into
Open
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
force-pushed
the
charlie/ohm-29-scope-unreachable-lint-inputs
branch
from
November 9, 2026 17:31
a8a5dd9 to
527bc82
Compare
charliermarsh
marked this pull request as ready for review
November 9, 2026 17:38
charliermarsh
force-pushed
the
charlie/ohm-29-scope-unreachable-lint-inputs
branch
from
November 17, 2026 07:31
527bc82 to
d39d2b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reading an unreachable-code lint’s span only when reporting it let
Lock::satisfiesreuse its type check. Over the local-impl lookup change, the edited resolver used 2.67% fewer instructions and the 14 compiler processes used 0.52% fewer. The finaluvlibrary used 0.15% more. Forced warnings and macro diagnostics still report the original source location. uv edit